[Housekeeping] Bubble up errors on fetching outputs + remove URL blob from GetExecutionData response #4724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ionData response Signed-off-by: Paul Dittamo <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4724 +/- ##
==========================================
+ Coverage 58.12% 58.14% +0.01%
==========================================
Files 626 626
Lines 53786 53747 -39
==========================================
- Hits 31263 31249 -14
+ Misses 20014 19998 -16
+ Partials 2509 2500 -9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
#4723
Why are the changes needed?
When remote store reads fail in GetOutputs or GetInputs, errors are not bubbled up - returning the URL blob to the client instead. However, the URL blob is deprecated. Sending a clear error status improves clarity.
What changes were proposed in this pull request?
How was this patch tested?
Added/updated unit tests
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link